Make Unknown the default Unknown untion types name

smithy-lang · Aug 23, 2024 · c4ba0b2 · c4ba0b2
1 parent e8540c2
commit c4ba0b2
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 26 deletions.
diff --git a/codegen/projections/rails_json/lib/rails_json/types.rb b/codegen/projections/rails_json/lib/rails_json/types.rb
diff --git a/codegen/projections/white_label/lib/white_label/event_stream.rb b/codegen/projections/white_label/lib/white_label/event_stream.rb
diff --git a/codegen/projections/white_label/lib/white_label/types.rb b/codegen/projections/white_label/lib/white_label/types.rb
diff --git a/...en/src/main/java/software/amazon/smithy/ruby/codegen/generators/EventStreamGenerator.java b/...en/src/main/java/software/amazon/smithy/ruby/codegen/generators/EventStreamGenerator.java
@@ -238,7 +238,7 @@ private void renderParseEventMethod(
                     }
                 })
                 .openBlock("else")
-                .write("$T::Unknown.new(name: type || 'unknown', value: message)",
+                .write("$T::Unknown.new(name: type, value: message)",
                         symbolProvider.toSymbol(eventStreamUnion))
                 .closeBlock("end")
                 .closeBlock("end");
@@ -267,9 +267,9 @@ private void renderParseExceptionMethod(
                     }
                 })
                 .openBlock("else")
-                .write("data = $T::Unknown.new(name: type || 'unknown', value: message)",
+                .write("data = $T::Unknown.new(name: type, value: message)",
                         symbolProvider.toSymbol(eventStreamUnion))
-                .write("Errors::ApiError.new(error_code: type || 'unknown', "
+                .write("Errors::ApiError.new(error_code: type, "
                         + "metadata: {data: data})")
                 .closeBlock("end")
                 .closeBlock("end");

diff --git a/...en/src/main/java/software/amazon/smithy/ruby/codegen/generators/types/UnionGenerator.java b/...en/src/main/java/software/amazon/smithy/ruby/codegen/generators/types/UnionGenerator.java
@@ -72,7 +72,7 @@ public void render() {
             writer
                     .openBlock("class Unknown < $T", symbolProvider.toSymbol(shape))
                     .openBlock("def initialize(name:, value:)")
-                    .write("super({name: name, value: value})")
+                    .write("super({name: name || 'Unknown', value: value})")
                     .closeBlock("end")
                     .write("")
                     .openBlock("def to_h")

diff --git a/hearth/sig/lib/hearth/http/api_error.rbs b/hearth/sig/lib/hearth/http/api_error.rbs