[OCU-138] Add fileURI support to additional SAST producers #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flowirtz
force-pushed
the
feature/ocu-138-switch-over-remaining-sast-producers-to-produce-file-uri
branch
from
010d4ba to
f3488bc
Compare
ptzianos
reviewed
Aug 5, 2024
|
|
||
| // Handle varying prefixes | ||
| filePath = strings.TrimPrefix(filePath, ".") // Remove leading dot |
There was a problem hiding this comment.
this doesn't look correct to me. the tests for this expect this path: file:///path/to/file.txt:1-2. if the code's current working directory is /home/app than I would expect the resulting path to be file:///home/app/path/to/file.txt:1-2. Also, there is a function in the standard library that performs this: https://pkg.go.dev/path/filepath#Clean
flowirtz
force-pushed
the
feature/ocu-138-switch-over-remaining-sast-producers-to-produce-file-uri
branch
from
f3488bc to
f54d449
Compare
|
I don't think this is relevant right now - will close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches over two more SAST producers to record their targets as fileURIs.