make oss migrations run as part of dev-dracon #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
northdpole
force-pushed
the
migrations-to-oss
branch
from
1a5625b to
4175acf
Compare
flowirtz
suggested changes
Aug 6, 2024
deploy/deduplication-db-migrations/chart/templates/migrations-job.yaml
Outdated
Show resolved
Hide resolved
flowirtz
reviewed
Aug 6, 2024
flowirtz
suggested changes
Aug 6, 2024
There was a problem hiding this comment.
make[1]: Leaving directory '/home/flo/Desktop/Git/dracon'
helm upgrade dracon-oss-components \
./dracon-oss-components-v0.27.0.tgz \
--install \
--namespace dracon \
--set container_registry=kind-registry:5000/ocurity/dracon \
--values ./deploy/deduplication-db-migrations/values/dev.yaml
Release "dracon-oss-components" does not exist. Installing it now.
Error: create: failed to create: namespaces "dracon" not found
make: *** [Makefile:242: dev-update-oss-components] Error 1
77c885f to
2b39a45
Compare
flowirtz
suggested changes
Aug 7, 2024
northdpole
force-pushed
the
migrations-to-oss
branch
from
2b39a45 to
95f0587
Compare
flowirtz
reviewed
Aug 7, 2024
the make install target is meant to be used for quickstart by pulling images and package from upstream while make dev-deploy is meant for building everything locally and used for local testing to create these targets this commit also installs migrations as part of the base installation and adds paralellism to all container publish targets
northdpole
force-pushed
the
migrations-to-oss
branch
from
b252ec7 to
a4079ce
Compare
flowirtz
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new ways of installing dracon
make dev-deploywill build everything and deploy it to the local clustermake installwill download the latest version of every package and install it to the local clusterboth commands first setup the local cluster in an idempotent way