-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#332 fix pdf consumer #333
Conversation
327a222
to
a36b7da
Compare
a36b7da
to
bb85e65
Compare
bb85e65
to
16af315
Compare
@northdpole can't we add some tests in this consumer since we know that it had bugs? |
@ptzianos , i'd need to mock S3 and orchestrate playwright which is a bit of a pain, I'm not saying it'd be a bad idea, but maybe not urgent as part of this pr? also this component has almost no logic, it orchestrates external apis only (load an html document in a browser, print pdf, upload to s3) this pr is not fixing bugs, it's making the component work with the make build system. |
@northdpole yes you would need to mock the S3 API and then probably build the container in the setup method of the tests and use that to orchestrate playwright and yes, it's going to be a bit of a pain, but this PR is not fixing any bugs because this component couldn't be executed until now, so it's not because it's been running consistently all this time. Even simple looking pieces of code could have bugs in them |
82a0328
to
253de8c
Compare
253de8c
to
5bbae16
Compare
5bbae16
to
e2b34be
Compare
e2b34be
to
a63af2d
Compare
closes #332 by adding a dockerfile and a makefile to the pdf consumer