Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#332 fix pdf consumer #333

Merged
merged 5 commits into from
Oct 24, 2024
Merged

#332 fix pdf consumer #333

merged 5 commits into from
Oct 24, 2024

Conversation

northdpole
Copy link
Contributor

closes #332 by adding a dockerfile and a makefile to the pdf consumer

components/consumers/pdf/main.go Outdated Show resolved Hide resolved
components/consumers/pdf/Dockerfile Outdated Show resolved Hide resolved
components/consumers/pdf/Dockerfile Outdated Show resolved Hide resolved
components/consumers/pdf/Makefile Outdated Show resolved Hide resolved
components/consumers/pdf/task.yaml Outdated Show resolved Hide resolved
components/consumers/pdf/Dockerfile Outdated Show resolved Hide resolved
components/consumers/pdf/Makefile Outdated Show resolved Hide resolved
components/consumers/pdf/Dockerfile Outdated Show resolved Hide resolved
components/consumers/pdf/main.go Outdated Show resolved Hide resolved
components/consumers/pdf/main.go Outdated Show resolved Hide resolved
@ptzianos
Copy link
Contributor

ptzianos commented Sep 4, 2024

@northdpole can't we add some tests in this consumer since we know that it had bugs?

components/consumers/pdf/main.go Outdated Show resolved Hide resolved
components/consumers/pdf/main.go Show resolved Hide resolved
@northdpole
Copy link
Contributor Author

northdpole commented Sep 5, 2024

@northdpole can't we add some tests in this consumer since we know that it had bugs?

@ptzianos , i'd need to mock S3 and orchestrate playwright which is a bit of a pain, I'm not saying it'd be a bad idea, but maybe not urgent as part of this pr? also this component has almost no logic, it orchestrates external apis only (load an html document in a browser, print pdf, upload to s3)

this pr is not fixing bugs, it's making the component work with the make build system.

@ptzianos
Copy link
Contributor

ptzianos commented Sep 6, 2024

@northdpole can't we add some tests in this consumer since we know that it had bugs?

@ptzianos , i'd need to mock S3 and orchestrate playwright which is a bit of a pain, I'm not saying it'd be a bad idea, but maybe not urgent as part of this pr? also this component has almost no logic, it orchestrates external apis only (load an html document in a browser, print pdf, upload to s3)

this pr is not fixing bugs, it's making the component work with the make build system.

@northdpole yes you would need to mock the S3 API and then probably build the container in the setup method of the tests and use that to orchestrate playwright and yes, it's going to be a bit of a pain, but this PR is not fixing any bugs because this component couldn't be executed until now, so it's not because it's been running consistently all this time. Even simple looking pieces of code could have bugs in them

@northdpole northdpole force-pushed the 332-fix-pdf-consumer branch 3 times, most recently from 82a0328 to 253de8c Compare October 24, 2024 15:24
components/consumers/pdf/Dockerfile Outdated Show resolved Hide resolved
components/consumers/pdf/Makefile Show resolved Hide resolved
components/consumers/pdf/main.go Outdated Show resolved Hide resolved
components/consumers/pdf/main.go Outdated Show resolved Hide resolved
components/consumers/pdf/main.go Outdated Show resolved Hide resolved
pkg/playwright/wrapper.go Outdated Show resolved Hide resolved
pkg/s3/wrapper.go Outdated Show resolved Hide resolved
pkg/s3/wrapper.go Outdated Show resolved Hide resolved
pkg/s3/wrapper.go Outdated Show resolved Hide resolved
pkg/s3/wrapper.go Outdated Show resolved Hide resolved
@northdpole northdpole force-pushed the 332-fix-pdf-consumer branch from 253de8c to 5bbae16 Compare October 24, 2024 16:02
@northdpole northdpole force-pushed the 332-fix-pdf-consumer branch from 5bbae16 to e2b34be Compare October 24, 2024 16:06
@northdpole northdpole force-pushed the 332-fix-pdf-consumer branch from e2b34be to a63af2d Compare October 24, 2024 16:14
@andream16 andream16 merged commit 086c18b into main Oct 24, 2024
3 checks passed
@andream16 andream16 deleted the 332-fix-pdf-consumer branch October 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdf consumer does needs to be updated to the new build system
3 participants