Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping buf to v2 to build correctly and removing out of date or unused dependencies #420

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Bumping buf to v2 to build correctly and removing out of date or unused dependencies #420

merged 2 commits into from
Oct 14, 2024

Conversation

andream16
Copy link
Contributor

@andream16 andream16 commented Oct 12, 2024 •
edited
Loading

  • Correctly migrating buf to v2
  • Remove unused dependencies (hence why the buf.lock is clean)
  • Run buf from docker for predictable outcomes
  • Bumping go proto dependencies

Done in preparation of generating oscf types.

andream16
andream16 commented Oct 14, 2024
View reviewed changes
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
buf.yaml Show resolved Hide resolved
buf.yaml Show resolved Hide resolved
@andream16
Bumping buf to v2 to build correctly and removing out of date or unus…
a3ac4e8 
…ed configuration. Bumping proto plugins to latest.
@andream16 andream16 force-pushed the andream16/refresh-buf-settings branch from 628d210 to bfff3bc Compare October 14, 2024 10:47
dlicheva
dlicheva reviewed Oct 14, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@andream16 andream16 force-pushed the andream16/refresh-buf-settings branch from bfff3bc to 6e99f5a Compare October 14, 2024 12:18
dlicheva
dlicheva approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@dlicheva dlicheva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@andream16 andream16 force-pushed the andream16/refresh-buf-settings branch from 6e99f5a to b5556dc Compare October 14, 2024 12:33
@andream16 andream16 force-pushed the andream16/refresh-buf-settings branch from b5556dc to 20c8e74 Compare October 14, 2024 12:39
@andream16 andream16 merged commit 10cb877 into main Oct 14, 2024
3 checks passed
@andream16 andream16 deleted the andream16/refresh-buf-settings branch October 14, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@northdpole northdpole northdpole approved these changes

@dlicheva dlicheva dlicheva approved these changes

@ptzianos ptzianos ptzianos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andream16 @northdpole @ptzianos @dlicheva