Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opened with sorted gitlog from changes in #443
PLEASE TAKE A LOOK AT THE README TO GET MORE CONTEXT BEFORE REVIEWING
Closes OCU-251, OCU-254, OCU-220, OCU-230, OCU-232
What's not covered:
What's covered:
Technical choices:
tools.go
, which runs the vendoredgomock
version, so we actually don't need to install it.export_test.go
file. The latter is a trick to export unexported bits that can't be used by a normal go app as the go build tool IGNORES symbols defined in_test.go
files. I did something similar withinternal
that can't be imported by other packages in general.sdk/component
. This was done to have a better UX for contributing as well as shorter import paths. This is a common thing done for OSS projects.component_name
,component_type
andsdk_version
as log fields to help us debugging issues.Attaching some sample logs from running a sample scanner:
Forgive me if the examples are a bit dummy but we can make a better job there when we have the storage later in place 🙏🏻