Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement embedded storage backend reader and writer - Part 1 #455

Conversation

andream16
Copy link
Contributor

@andream16 andream16 commented Oct 30, 2024

Preparing to finish up the implementation with SQLite by:

  • setting up things for SQLite in term of dependencies
  • support reading the supplied workflow_id from the environment and leverage it for storing purposes in Read, Update and Write. We need such ID to connect the dots when writing and updating findings in the DB.

We agreed with @ptzianos to leverage the workflow_id from env var for now. We can cover the instance_id separately :)


I added a reusable uuid package which wraps google's UUID. Why? Because we're in charge of swapping the implementation and the interfaces don't have 3rd party dependencies.


What did I do?

  • Added SQLite and sample TO BE IMPLEMENTED code
  • Added reusable UUID package
  • Passing workflow_id around where needed - also to be tracked in logs
  • Refreshed examples, runners and tests to use the workflow_id

In the next PR

  • Implement SQLite layer
  • Write integration tests for SQLite layer

@andream16 andream16 self-assigned this Oct 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11598873281

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.631%

Totals Coverage Status
Change from base Build 11572665249: 0.0%
Covered Lines: 3375
Relevant Lines: 8107

💛 - Coveralls

@andream16 andream16 merged commit e6c1327 into main Oct 31, 2024
3 checks passed
@andream16 andream16 deleted the feature/ocu-221-implement-embedded-storage-backend-reader-and-writer branch October 31, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants