Implement embedded storage backend reader and writer - Part 2 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andream16
commented
Oct 31, 2024
Pull Request Test Coverage Report for Build 11682502082Details
💛 - Coveralls |
andream16
commented
Oct 31, 2024
northdpole
approved these changes
Nov 1, 2024
ptzianos
reviewed
Nov 1, 2024
andream16
force-pushed
the
feature/ocu-221-implement-embedded-storage-backend-reader-and-writer-pt-2
branch
2 times, most recently
from
fd3eb65 to
914277c
Compare
andream16
force-pushed
the
feature/ocu-221-implement-embedded-storage-backend-reader-and-writer-pt-2
branch
from
914277c to
35461f9
Compare
ptzianos
reviewed
Nov 4, 2024
andream16
force-pushed
the
feature/ocu-221-implement-embedded-storage-backend-reader-and-writer-pt-2
branch
from
35461f9 to
15eff97
Compare
ptzianos
approved these changes
Nov 5, 2024
andream16
deleted the
feature/ocu-221-implement-embedded-storage-backend-reader-and-writer-pt-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple local SQLite setup to put together a POC for Tuesday.
Right now I decided to set it up to convert the ocsf proto to JSON and storing it alongside a workflow id. This is done only for building the POC quickly - it shouldn't be the final solution.
We can work together when you are back @ptzianos to organise the data in the DB in a way that makes sense.
I didn't spend time on migrations as we might change the structure and we'll run them from the local potato engine for the POC demo.
Next steps: