Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: PDF consumer format #470

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Feature: PDF consumer format #470

merged 1 commit into from
Nov 13, 2024

Conversation

dlicheva
Copy link
Contributor

@dlicheva dlicheva commented Nov 7, 2024 •
edited
Loading

Ticket
This PR adds styles and a bit of logic to the PDF consumer.

  • fix missing HTML file result
  • calculate total and high priority findings
  • summarise findings in a list with links to details
  • hide empty vulnerability rows
  • colour coding per priority
  • parse dates and display them in a human format
  • added link to CWE
  • added test data into the folder
  • add "seen before" to summary table at the top

Screenshot from 2024-11-12 17-24-55

report.pdf

@dlicheva dlicheva marked this pull request as draft November 7, 2024 18:40
@coveralls
Copy link

coveralls commented Nov 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11803650750

Details

  • 18 of 29 (62.07%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 40.273%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/consumers/pdf/main.go 18 29 62.07%
Totals Coverage Status
Change from base Build 11781647353: 0.1%
Covered Lines: 3389
Relevant Lines: 8415
💛 - Coveralls

@dlicheva dlicheva force-pushed the bugifx/pdf-format-2 branch from b01f826 to 5b72a61 Compare November 8, 2024 17:37
@dlicheva dlicheva marked this pull request as ready for review November 8, 2024 17:44
andream16
andream16 approved these changes Nov 12, 2024
View reviewed changes
components/consumers/pdf/README.md Show resolved Hide resolved
components/consumers/pdf/main.go Outdated Show resolved Hide resolved
@dlicheva dlicheva force-pushed the bugifx/pdf-format-2 branch from ba7a294 to bad3aa2 Compare November 12, 2024 18:41
@dlicheva dlicheva merged commit 54476f7 into main Nov 13, 2024
3 checks passed
@dlicheva dlicheva deleted the bugifx/pdf-format-2 branch November 13, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andream16 andream16 andream16 approved these changes

@northdpole northdpole northdpole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlicheva @coveralls @northdpole @andream16