-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement persistent findings storage - Part 4 #496
Merged
andream16
merged 10 commits into
main
from
andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4
Dec 16, 2024
Merged
Implement persistent findings storage - Part 4 #496
andream16
merged 10 commits into
main
from
andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a7fd76
to
2e8678c
Compare
6c67e5a
to
d7ecdd8
Compare
2e8678c
to
e05c372
Compare
d7ecdd8
to
8b46337
Compare
e05c372
to
ad780dc
Compare
8b46337
to
9920617
Compare
This was referenced Dec 12, 2024
9920617
to
24ffbf0
Compare
Note for other testers: I also had to add this to every component that uses a volume in
|
dlicheva
previously approved these changes
Dec 12, 2024
ad780dc
to
491297f
Compare
24ffbf0
to
e0b7295
Compare
820a336
to
eddb99b
Compare
Base automatically changed from
andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-3
to
main
December 16, 2024 15:27
e0b7295
to
bf5d639
Compare
ptzianos
approved these changes
Dec 16, 2024
…postgres configuration.
bf5d639
to
5fc6a36
Compare
dlicheva
reviewed
Dec 16, 2024
dlicheva
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #494 and after publishing a new SDK version.
Plugging everything together using a persistent storage on top of psql in the existing gosec workflow:
How to test:
new-components
docker-compose up --build --force-recreate
docker-compose down --rmi all
to shut everything down