Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement persistent findings storage - Part 4 #496

Conversation

andream16
Copy link
Contributor

@andream16 andream16 commented Dec 9, 2024

To be merged after #494 and after publishing a new SDK version.

image


Plugging everything together using a persistent storage on top of psql in the existing gosec workflow:

  • updating to temporary version of SDK
  • sample docker-compose pipeline

How to test:

  • go inside new-components
  • run docker-compose up --build --force-recreate
  • check that everything builds fine
  • check the logs from the final json-logger to output one vuln
  • run docker-compose down --rmi all to shut everything down

@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-3 branch 2 times, most recently from 3a7fd76 to 2e8678c Compare December 9, 2024 17:47
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4 branch 2 times, most recently from 6c67e5a to d7ecdd8 Compare December 10, 2024 15:03
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-3 branch from 2e8678c to e05c372 Compare December 10, 2024 16:51
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4 branch from d7ecdd8 to 8b46337 Compare December 11, 2024 12:25
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-3 branch from e05c372 to ad780dc Compare December 11, 2024 17:55
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4 branch from 8b46337 to 9920617 Compare December 11, 2024 17:56
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4 branch from 9920617 to 24ffbf0 Compare December 12, 2024 14:38
@andream16 andream16 changed the title [WIP] - Implement persistent findings storage - Part 4 Implement persistent findings storage - Part 4 Dec 12, 2024
@andream16 andream16 self-assigned this Dec 12, 2024
@andream16 andream16 marked this pull request as ready for review December 12, 2024 14:41
@dlicheva
Copy link
Contributor

dlicheva commented Dec 12, 2024

Note for other testers:
I had to install Docker-compose because my docker wouldn't work with it out of the box.

I also had to add this to every component that uses a volume in new-components/docker-compose.yaml:

    user: "${UID}:${GID}"
    environment:
      - UID=${UID}
      - GID=${GID}

dlicheva
dlicheva previously approved these changes Dec 12, 2024
@andream16 andream16 marked this pull request as draft December 13, 2024 16:04
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-3 branch from ad780dc to 491297f Compare December 16, 2024 10:10
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4 branch from 24ffbf0 to e0b7295 Compare December 16, 2024 10:58
@andream16 andream16 marked this pull request as ready for review December 16, 2024 10:58
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-3 branch 4 times, most recently from 820a336 to eddb99b Compare December 16, 2024 14:08
Base automatically changed from andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-3 to main December 16, 2024 15:27
@andream16 andream16 dismissed dlicheva’s stale review December 16, 2024 15:27

The base branch was changed.

@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4 branch from e0b7295 to bf5d639 Compare December 16, 2024 15:33
@andream16 andream16 force-pushed the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4 branch from bf5d639 to 5fc6a36 Compare December 16, 2024 16:02
Copy link
Contributor

@dlicheva dlicheva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 🙌

@andream16 andream16 merged commit fde5a9b into main Dec 16, 2024
3 checks passed
@andream16 andream16 deleted the andream16/feature/saas-610/implement-findings-storage-gateway-reader-and-writer/pt-4 branch December 16, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants