Open Sourcing V1 Types #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andream16
force-pushed
the
feature/saas-604-switch-saas-to-use-oss-v1-data-types
branch
3 times, most recently
from
afe7b8f to
eb4dd9d
Compare
andream16
requested review from
northdpole,
ptzianos,
dlicheva and
PTruscott
dlicheva
approved these changes
Dec 18, 2024
ptzianos
reviewed
Dec 19, 2024
andream16
force-pushed
the
feature/saas-604-switch-saas-to-use-oss-v1-data-types
branch
from
eb4dd9d to
711550f
Compare
dlicheva
approved these changes
Dec 19, 2024
andream16
deleted the
feature/saas-604-switch-saas-to-use-oss-v1-data-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving useful V1 types from SAAS to OSS so we can start working on smithyctl.
All types have been moved except Instances, which are a SAAS only concern.
GORM and Kubernetes specific fields or helpers have been removed. These will be mapped in SAAS with an adapter layer.
In general, avoiding using pointers to make types and fields safer to use.
Next steps: