Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace please with Makefile #53

Merged
merged 84 commits into from
Mar 11, 2024

Conversation

ptzianos
Copy link
Contributor

@ptzianos ptzianos commented Dec 4, 2023

This PR removes all please related configuration from the repository and replaces it with Makefile.

Changes include the following:

  • Remove all BUILD files*
  • Remove k3d documentation
  • Update KiND documentation**
  • Add documentation about all the components that require to be deployed
  • Cleanup example pipelines
  • Add files to allow users to deploy examples with helm
  • Cleanup openapi tests
  • Fix Github code quality checks
    • test
    • lint
    • format
    • test coverage
  • Add Github actions for producing releases based on tags
  • Allow user to define custom base images for components
  • Add draconctl to build pipelines and deprecate the kustomize-component-generator
  • Add draconctl subcommand for managing migrations

* some BUILD files will remain in the repo, since they might be related to parts of the code that we need to discuss in the future if we want to support at all or if we want to completely get rid of
** KiND is the only officially supported deployment method at this point. users are going to be free to choose other methods of running their local clusters should they wish to. updated documentation will reflect this change

Closes #62, #63, #64, #65, #66, #67, #68, #69, #70, #71, #72, #73, #74, #90, #101, #102, #103, #104, #105, #106, #107, #108, #109, #112, #118

@northdpole
Copy link
Contributor

great job pavlos!

@ptzianos ptzianos force-pushed the pavlostzianos/remove-please branch from 49a0c6e to 1e46215 Compare December 25, 2023 22:45
@ptzianos ptzianos force-pushed the pavlostzianos/remove-please branch 8 times, most recently from c93dab3 to d1ff855 Compare January 23, 2024 11:33
@ptzianos ptzianos force-pushed the pavlostzianos/remove-please branch 6 times, most recently from e6d2194 to b443cab Compare January 29, 2024 20:28
@ptzianos ptzianos self-assigned this Jan 29, 2024
@ptzianos ptzianos force-pushed the pavlostzianos/remove-please branch 7 times, most recently from b1145d4 to b8e2943 Compare February 5, 2024 11:37
@ptzianos ptzianos force-pushed the pavlostzianos/remove-please branch 4 times, most recently from 470fd22 to 7403b87 Compare February 15, 2024 16:17
Pavlos Tzianos and others added 22 commits March 11, 2024 19:42
…#109)

For some reason the main workspace used by all our components is called
source-code-ws. However, the default workspace used by the `git-clone`
task is called `output`. This is a more appropriate name because what we
are actually doing is get the `git-clone` task to clone the source code
into the `source-code` subdirectory of the volume and then all the rest
of the components are using that path and are creating their own
subdirectories to store their results. Using a different workspace than
the one used by default from the git-clone task is not a huge problem
but it requires us to either vendorize the taks and modify it, or add
extra configuration to an already very verbose pipeline to reference
everywhere the `output` workspace as `source-code-ws`. Clearly the
optimal solution is to reduce the hacks, hence this commit that
homogenises the whole repo to just use `output` as the workspace where
everything will be store.

Signed-off-by: Pavlos Tzianos <[email protected]>
This anchor is now added automatically when the pipeline is being
assembled and it's added as the last step in the task.

Signed-off-by: Pavlos Tzianos <[email protected]>
)

Lately, a security feature has been added in Git where if the user
running the Git process is different than the user owning the repo, Git
will throw an error. Unless the repo has been added explicitly to a list
of safe repos.
This is an issue that affects the first step of the Nancy task, because
it uses Go tooling to list the dependencies of the repo. Go itself
figures out that it's a git repo that is being processed and invokes git
which in turn fails, because the process is running by the root user by
the volume with the source code is mounted with owner ID 65534, causing
git to throw an error and Go tools to fail. To overcome this we mark the
source code repository as safe in when the task starts.

Signed-off-by: Pavlos Tzianos <[email protected]>
@ptzianos ptzianos force-pushed the pavlostzianos/remove-please branch from 750deff to 338e01b Compare March 11, 2024 19:44
@ptzianos ptzianos merged commit b9c40bf into smithy-security:main Mar 11, 2024
3 checks passed
@ptzianos ptzianos deleted the pavlostzianos/remove-please branch March 11, 2024 19:53
@northdpole northdpole mentioned this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace please with Makefile
2 participants