-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace please with Makefile #53
Merged
ptzianos
merged 84 commits into
smithy-security:main
from
ptzianos:pavlostzianos/remove-please
Mar 11, 2024
Merged
Replace please with Makefile #53
ptzianos
merged 84 commits into
smithy-security:main
from
ptzianos:pavlostzianos/remove-please
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
great job pavlos! |
northdpole
approved these changes
Dec 24, 2023
ptzianos
force-pushed
the
pavlostzianos/remove-please
branch
from
December 25, 2023 22:45
49a0c6e
to
1e46215
Compare
ptzianos
force-pushed
the
pavlostzianos/remove-please
branch
8 times, most recently
from
January 23, 2024 11:33
c93dab3
to
d1ff855
Compare
ptzianos
force-pushed
the
pavlostzianos/remove-please
branch
6 times, most recently
from
January 29, 2024 20:28
e6d2194
to
b443cab
Compare
ptzianos
force-pushed
the
pavlostzianos/remove-please
branch
7 times, most recently
from
February 5, 2024 11:37
b1145d4
to
b8e2943
Compare
ptzianos
force-pushed
the
pavlostzianos/remove-please
branch
4 times, most recently
from
February 15, 2024 16:17
470fd22
to
7403b87
Compare
…security#104) Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
…te (Part of smithy-security#62) Signed-off-by: Pavlos Tzianos <[email protected]>
…rity#62) Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
…y#62) Signed-off-by: Pavlos Tzianos <[email protected]>
…-security#62) Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
…#109) For some reason the main workspace used by all our components is called source-code-ws. However, the default workspace used by the `git-clone` task is called `output`. This is a more appropriate name because what we are actually doing is get the `git-clone` task to clone the source code into the `source-code` subdirectory of the volume and then all the rest of the components are using that path and are creating their own subdirectories to store their results. Using a different workspace than the one used by default from the git-clone task is not a huge problem but it requires us to either vendorize the taks and modify it, or add extra configuration to an already very verbose pipeline to reference everywhere the `output` workspace as `source-code-ws`. Clearly the optimal solution is to reduce the hacks, hence this commit that homogenises the whole repo to just use `output` as the workspace where everything will be store. Signed-off-by: Pavlos Tzianos <[email protected]>
This anchor is now added automatically when the pipeline is being assembled and it's added as the last step in the task. Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
) Lately, a security feature has been added in Git where if the user running the Git process is different than the user owning the repo, Git will throw an error. Unless the repo has been added explicitly to a list of safe repos. This is an issue that affects the first step of the Nancy task, because it uses Go tooling to list the dependencies of the repo. Go itself figures out that it's a git repo that is being processed and invokes git which in turn fails, because the process is running by the root user by the volume with the source code is mounted with owner ID 65534, causing git to throw an error and Go tools to fail. To overcome this we mark the source code repository as safe in when the task starts. Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]> Signed-off-by: Pavlos Tzianos <[email protected]>
…(Part of smithy-security#62) Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
…hy-security#118) Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
Signed-off-by: Pavlos Tzianos <[email protected]>
ptzianos
force-pushed
the
pavlostzianos/remove-please
branch
from
March 11, 2024 19:44
750deff
to
338e01b
Compare
This was referenced Mar 12, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all please related configuration from the repository and replaces it with Makefile.
Changes include the following:
* some BUILD files will remain in the repo, since they might be related to parts of the code that we need to discuss in the future if we want to support at all or if we want to completely get rid of
** KiND is the only officially supported deployment method at this point. users are going to be free to choose other methods of running their local clusters should they wish to. updated documentation will reflect this change
Closes #62, #63, #64, #65, #66, #67, #68, #69, #70, #71, #72, #73, #74, #90, #101, #102, #103, #104, #105, #106, #107, #108, #109, #112, #118