Slack to new sdk #727
Open
Slack to new sdk #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andream16
reviewed
Feb 3, 2025
northdpole
force-pushed
the
slack-to-new-sdk
branch
2 times, most recently
from
236b4bb to
d74ef4d
Compare
andream16
approved these changes
Feb 3, 2025
northdpole
force-pushed
the
slack-to-new-sdk
branch
from
d74ef4d to
04e8072
Compare
andream16
reviewed
Feb 11, 2025
| With(slog.Int("num_findings", len(findings))) | ||
|
|
||
| if len(findings) > 0 { | ||
| scanID := findings[0].Finding.FindingInfo.Uid |
There was a problem hiding this comment.
How come we don't do it for all findings? I guess we could handle that with a for loop
There was a problem hiding this comment.
my assumption was that this is called for a single scan so everything should have the same scanID
northdpole
force-pushed
the
slack-to-new-sdk
branch
from
04e8072 to
e6e2501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.