-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multitool deduplication #93
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@@ -0,0 +1,245 @@ | |||
package main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [go/revive] reported by reviewdog 🐶
should have a package comment
connStr string | ||
readPath string | ||
writePath string | ||
cve map[string][]tooledIssue = map[string][]tooledIssue{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [go/revive] reported by reviewdog 🐶
should omit type map[string][]tooledIssue from declaration of var cve; it will be inferred from the right-hand side
return res | ||
} | ||
|
||
func BDTargetToPurl(originName, originID string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [go/revive] reported by reviewdog 🐶
exported function BDTargetToPurl should have comment or be unexported
@@ -0,0 +1,242 @@ | |||
// package main of the multitool deduplication enricher finds and tags issues found by multiple tools in this scan | |||
|
|||
package main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [go/revive] reported by reviewdog 🐶
should have a package comment
// else if the issue does not have a CWE | ||
// TODO match if the tool is SAST, match title and description (and content of remote references) to CRE, try to match to CREs of other tools | ||
|
||
const AnnotationStr = "Found By Other Tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [go/revive] reported by reviewdog 🐶
exported const AnnotationStr should have comment or be unexported
} | ||
return &scan | ||
} | ||
func TestHandlePurl(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[go/fmt] reported by reviewdog 🐶
func TestHandlePurl(t *testing.T) { | |
func TestHandlePurl(t *testing.T) { |
log.Println(err) | ||
continue | ||
} | ||
res = append(res, int32(newIntID)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [go/gosec] reported by reviewdog 🐶
[CWE-190] Potential Integer overflow made by strconv.Atoi result conversion to int16/32 (Rule:G109, Severity:HIGH, Confidence:MEDIUM)
No description provided.