Automatically activate Booster Energy during weather/terrain changes

[andrebastosdias]

https://www.smogon.com/forums/threads/scarlet-violet-battle-mechanics-research.3709545/post-10411500

Ninetales-Alola, Roaring Moon, Incineroar and Torkoal switch in:

1. Ninetales' Snow Warning activates.
2. Roaring Moon's Booster Energy activates, boosting its Attack.
3. Incineroar's Intimidate activates.
4. Torkoal's Drought activates.

[pyuk-bot]

I think it would be a lot simpler to just have Protosynthesis and Quark Drive handle activating Booster Energy themselves.

[andrebastosdias]

Just the onWeatherChange, or the onUpdate as well? I though about that, but you would still need some kind of onUpdate for when Booster Energy is tricked to you. I don't know how much that would simplify things.

[pyuk-bot]

Just the onWeatherChange part

[andrebastosdias]

I don't know. It is basically the same amount of code with one less method, and I think it makes less sense from a Separation of Concerns point of view. Protosynthesis exists on its own, while Booster Energy doesn't.

[pyuk-bot]

Yeah, I suppose it’s better to have all the isTransformed checks in one place, and I wouldn’t put it past Game Freak to bring back Protosynthesis and Quark Drive in a future gen without Booster Energy.

[andrebastosdias]

It should work with OMs now.

[HisuianZoroark]

using getAbility() like that directly can lead to wonky interactions in OMs like Shared Power or Pokebilities AAA, so it might be best to hardcode the sourceEffect directly

[andrebastosdias]

I'm one problem away from calling pokemon.addVolatile('protosynthesis', pokemon, pokemon.getItem()) directly from the ability's code.

[pyuk-bot]

That sounds like a good idea, actually. The less Booster Energy handles itself, the better. That also lets you leave out the onUseItem check.