Use PHP 8.1 never return type (#1184)

This replaces the `@return never` docstring used by some CI tools.

Related to #1183.

src/bootstrap.php

@@ -106,7 +106,7 @@ function handleException(Throwable $e) : void {
 /**
  * Can be used to convert any type of notice into an exception.
  */
-function exception_error_handler($errno, $errstr, $errfile, $errline) {
+function exception_error_handler($errno, $errstr, $errfile, $errline) : never {
 	throw new ErrorException($errstr, $errno, E_ERROR, $errfile, $errline);
 }
 

src/engine/Default/alliance_set_op_processing.php

@@ -6,10 +6,7 @@
 $account = $session->getAccount();
 $player = $session->getPlayer();
 
-/**
- * @return never
- */
-function error_on_page(string $error) : void {
+function error_on_page(string $error) : never {
 	$message = '<span class="bold red">ERROR:</span> ' . $error;
 	Page::create('skeleton.php', 'alliance_set_op.php', array('message' => $message))->go();
 }

src/engine/Default/chat_sharing_processing.php

@@ -4,10 +4,7 @@
 $session = Smr\Session::getInstance();
 $player = $session->getPlayer();
 
-/**
- * @return never
- */
-function error_on_page(string $message) : void {
+function error_on_page(string $message) : never {
 	$message = '<span class="bold red">ERROR:</span> ' . $message;
 	Page::create('skeleton.php', 'chat_sharing.php', array('message' => $message))->go();
 }

src/lib/Default/Page.class.php

@@ -144,10 +144,8 @@ public static function copy(Page $other) : self {
 
 	/**
 	 * Forward to the page identified by this container.
-	 *
-	 * @return never
 	 */
-	public function go() : void {
+	public function go() : never {
 		if (defined('OVERRIDE_FORWARD') && OVERRIDE_FORWARD === true) {
 			overrideForward($this);
 		}

src/lib/Default/smr.inc.php

@@ -184,10 +184,7 @@ function bbifyMessage(string $message, bool $noLinks = false) : string {
 	return $message;
 }
 
-/**
- * @return never
- */
-function create_error(string $message) : void {
+function create_error(string $message) : never {
 	$container = Page::create('skeleton.php', 'error.php');
 	$container['message'] = $message;
 	if (USING_AJAX) {
@@ -297,10 +294,8 @@ function pluralise(string $word, float $count = 0) : string {
  * This function is a hack around the old style http forward mechanism.
  * It is also responsible for setting most of the global variables
  * (see loader.php for the initialization of the globals).
- *
- * @return never
  */
-function do_voodoo() : void {
+function do_voodoo() : never {
 	global $lock;
 
 	$session = Smr\Session::getInstance();

src/tools/npc/npc.php

@@ -3,10 +3,7 @@
 // Use this exception to help override container forwarding for NPC's
 class ForwardException extends Exception {}
 
-/**
- * @return never
- */
-function overrideForward(Page $container) : void {
+function overrideForward(Page $container) : never {
 	global $forwardedContainer;
 	$forwardedContainer = $container;
 	if ($container['body'] == 'error.php') {
@@ -335,10 +332,7 @@ function debug(string $message, mixed $debugObject = null) : void {
 	}
 }
 
-/**
- * @return never
- */
-function processContainer(Page $container) : void {
+function processContainer(Page $container) : never {
 	global $forwardedContainer, $previousContainer;
 	$session = Smr\Session::getInstance();
 	$player = $session->getPlayer();