Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SectorsFile.php: remove unintentional indentation #1787

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

hemberger
Copy link
Member

As a result of the indentation for the switch from engine pages to Page classes in 5825816, literal multi-line strings were accidentally prepended with tabs. This extra whitespace broke importing the SMR file in MGU.

We remove the prepended whitespace here by avoiding literal multiline strings.

As a result of the indentation for the switch from engine pages to Page
classes in 5825816, literal multi-line strings were accidentally
prepended with tabs. This extra whitespace broke importing the SMR file
in MGU.

We remove the prepended whitespace here by avoiding literal multiline
strings.
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (dd66783) 30.80% compared to head (fc3037d) 30.79%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/lib/Smr/SectorsFile.php 0.00% 21 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1787      +/-   ##
============================================
- Coverage     30.80%   30.79%   -0.01%     
  Complexity     4023     4023              
============================================
  Files           125      125              
  Lines         12792    12796       +4     
============================================
  Hits           3940     3940              
- Misses         8852     8856       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hemberger hemberger merged commit d1283de into smrealms:main Feb 16, 2024
6 of 8 checks passed
@hemberger hemberger deleted the fix-smr-file-tabs branch February 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant