Fix format_time pluralization #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pluralise` function was not returning the correct pluralization for identically 1 float values. Since ceil/floor return a float, this was causing `format_time` to return strings like "1 minutes" instead of "1 minute". This is fixed by casting the value to a float in the comparison to 1 in `pluralise`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1990 +/- ##
============================================
+ Coverage 31.45% 31.74% +0.28%
Complexity 4205 4205
============================================
Files 125 125
Lines 12815 12815
============================================
+ Hits 4031 4068 +37
+ Misses 8784 8747 -37 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pluralisefunction was not returning the correct pluralization for identically 1 float values. Since ceil/floor return a float, this was causingformat_timeto return strings like "1 minutes" instead of "1 minute".This is fixed by casting the value to a float in the comparison to 1 in
pluralise.