Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove everything related to the old deposit return voucher logic (Apps-1644) #227

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Remove everything related to the old deposit return voucher logic (Apps-1644) #227

merged 3 commits into from
Dec 17, 2024

Conversation

Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Dec 10, 2024 •
edited
Loading

The old logic related to the deposit return voucher has been removed.

APPS-1644

How to test?

Launch the app and test shopping cart related stuff. Scan or add different products to see if the product look up still works.

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

@Fabtron Fabtron changed the base branch from main to feature-deposit-return-voucher December 10, 2024 12:03
@Fabtron Fabtron marked this pull request as ready for review December 10, 2024 12:04
@Fabtron Fabtron requested a review from cmaier December 16, 2024 12:42
cmaier
cmaier suggested changes Dec 17, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Fabtron Fabtron requested a review from cmaier December 17, 2024 13:07
@Fabtron Fabtron merged commit 230e504 into feature-deposit-return-voucher Dec 17, 2024
1 check passed
@Fabtron Fabtron deleted the apps-1644-remove-old-deposit-logic branch December 17, 2024 13:28
@Fabtron Fabtron mentioned this pull request Dec 19, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaier cmaier cmaier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fabtron @cmaier