Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fitsSystemWindows for edge-to-edge support #238

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

cmaier
Copy link
Contributor

@cmaier cmaier commented Jan 21, 2025

Improve edge-to-edge support for apps targeting Android API level 35 by adding android:fitsSystemWindows="true" to the layouts used in activities.

How to test?

  • Integrate this branch in our latest App project
  • Start Scan&Go and test e.g. this:
    • adding a credit card should not be in bounds
    • the checkout process should now be in bounds

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

@cmaier cmaier self-assigned this Jan 21, 2025
@cmaier cmaier marked this pull request as ready for review January 21, 2025 08:57
@cmaier cmaier requested a review from Fabtron January 21, 2025 09:56
@cmaier cmaier merged commit 375d29e into main Jan 21, 2025
1 check passed
@cmaier cmaier deleted the improve-edge-to-edge-support branch January 21, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants