Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Legacy JetStream API and Update updateStream Function #10

Closed
wants to merge 5 commits into from

Conversation

kianaza
Copy link
Collaborator

@kianaza kianaza commented Jul 16, 2024

  • Replace legacy JetStream API with the new JetStream API.

  • Update the updateStream function to prevent configuration changes during stream updates.

@kianaza kianaza requested a review from sinamna July 16, 2024 11:09
@kianaza kianaza self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 74 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3f7b729) to head (2b39ef8).
Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
internal/natsclient/jetstream.go 0.00% 70 Missing ⚠️
internal/cmd/main.go 0.00% 3 Missing ⚠️
internal/config/default.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #10   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          9       9           
  Lines        296     308   +12     
=====================================
- Misses       296     308   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1995parham 1995parham closed this Oct 2, 2024
@1995parham 1995parham deleted the upgrade/new-jetsrtream-client branch October 2, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants