Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add orca engine #1

Merged
merged 17 commits into from
Oct 21, 2024
Merged

add orca engine #1

merged 17 commits into from
Oct 21, 2024

Conversation

ArshiaDadras
Copy link
Contributor

This is a merge request (MR) with exactly the same changes as MR51 in GitLab, and it has the same title as well.

@SamMHD
Copy link
Collaborator

SamMHD commented Sep 24, 2024

@ArshiaDadras jan, Pipelines are failing, can you check on them?

@pedy4000
Copy link
Contributor

@ArshiaDadras Jan, Please change SDK version in "version/version.go" file.

@ArshiaDadras
Copy link
Contributor Author

ArshiaDadras commented Sep 24, 2024

@ArshiaDadras jan, Pipelines are failing, can you check on them?

@SamMHD jan, I noticed those errors. However, my changes didn't affect those parts, and as you can see, these errors were already present in the last commit of the main branch of the project! I can try to fix them, but some of the errors seem to be in services like search or reverse, and I think it might not be ideal for me to change them on my own. Still, I'm happy to do so if needed.

Update 1: I changed some parts to fix these lint errors.

Update 2: I changed some parts of the workflow (Golang version and adding -buildvcs=false to its environments) to fix the test error in the pipeline. We have no errors anymore.

@pedy4000 pedy4000 merged commit f3ee813 into snapp-incubator:main Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants