Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(env): add environment variables for configuring score api and sidekick #635

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

Todmy
Copy link
Contributor

@Todmy Todmy commented Aug 7, 2023

No description provided.

@Todmy Todmy requested review from wa0x6e and ChaituVR August 7, 2023 15:51
@Todmy Todmy self-assigned this Aug 7, 2023
@@ -6,7 +6,8 @@ import { capture } from '@snapshot-labs/snapshot-sentry';
export let strategies: any[] = [];
export let strategiesObj: any = {};

const uri = 'https://score.snapshot.org/api/strategies';
const scoreApiEndpoint = process.env.SCORE_API_URL || 'https://score.snapshot.org';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be named scoreApiURL like the rest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Todmy Todmy requested a review from wa0x6e August 8, 2023 10:53
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@Todmy Todmy merged commit 7b32c35 into master Aug 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants