feat(passport-gated): stamps as optional parameter #4279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@santteegt is attempting to deploy a commit to the snapshot Team on Vercel. A member of the Team first needs to authorize it. |
|
This is an open source contribution. I'd appreciate it if you guys add the |
|
Why this is closed 🤔 |
|
Must have been a miss click |
ChaituVR
reviewed
Nov 14, 2023
| @@ -741,7 +741,7 @@ | |||
| "passport-gated": { | |||
| "label": "Gitcoin Passport gated", | |||
| "description": "Protect your space from spam by requiring users to have a Gitcoin Passport to create a proposal.", | |||
| "invalidMessage": "You need a Gitcoin Passport with score above {scoreThreshold} and {operator} of the following stamps to vote on this proposal: {stamps}. " | |||
| "invalidMessage": "You need a Gitcoin Passport with score above {scoreThreshold} and {operator} of the following stamps to create a proposal: {stamps}. " | |||
There was a problem hiding this comment.
I think this still be used inside proposal
There was a problem hiding this comment.
Suggested change
| "invalidMessage": "You need a Gitcoin Passport with score above {scoreThreshold} and {operator} of the following stamps to create a proposal: {stamps}. " | |
| "invalidMessage": "You need a Gitcoin Passport with a score above {scoreThreshold} and {operator} of the following stamps: {stamps}. " |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Continued here as I couldn't edit this PR #4357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
passport-gatedinfo/warning messages and initial parameter setup to cover the latest updates introduced in snapshot-labs/snapshot-strategies#1309