Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add space param to strategy playground #4941

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Dec 1, 2024

Summary

This PR adds the space params to the strategy playground.

Currently, we pass a hardcoded empty string as space when testing strategies, but some strategies like "split-delegation" have specific voting power for each space.

This PR adds a new "space" input to the playground, defaulting to empty string.

How to test

  1. Go to http://localhost:8081/#/playground/split-delegation?query=eyJwYXJhbXMiOnsiYmFja2VuZFVybCI6Imh0dHBzOi8vZGVsZWdhdGUtYXBpLmdub3Npc2d1aWxkLm9yZyIsInN0cmF0ZWdpZXMiOlt7Im5hbWUiOiJlcmMyMC1iYWxhbmNlLW9mIiwicGFyYW1zIjp7InN5bWJvbCI6InZDT1cgKG1haW5uZXQpIiwiYWRkcmVzcyI6IjB4ZDA1N2I2M2Y1ZTY5Y2YxYjkyOWIzNTZiNTc5Y2JhMDhkNzY4ODA0OCIsImRlY2ltYWxzIjoxOH0sIm5ldHdvcmsiOiIxIn0seyJuYW1lIjoiZXJjMjAtYmFsYW5jZS1vZiIsInBhcmFtcyI6eyJzeW1ib2wiOiJ2Q09XIChHQykiLCJhZGRyZXNzIjoiMHhjMjBDOUMxM0U4NTNmYzY0ZDA1NGI3M2ZGMjFkMzYzNkIyZDk3ZWFCIiwiZGVjaW1hbHMiOjE4fSwibmV0d29yayI6IjEwMCJ9LHsibmFtZSI6ImVyYzIwLWJhbGFuY2Utb2YiLCJwYXJhbXMiOnsic3ltYm9sIjoiQ09XIChNYWlubmV0KSIsImFkZHJlc3MiOiIweERFZjFDQTFmYjdGQmNEQzc3NzUyMGFhN2YzOTZiNEUwMTVGNDk3YUIiLCJkZWNpbWFscyI6MTh9LCJuZXR3b3JrIjoiMSJ9LHsibmFtZSI6ImVyYzIwLWJhbGFuY2Utb2YiLCJwYXJhbXMiOnsic3ltYm9sIjoiQ09XIChHQykiLCJhZGRyZXNzIjoiMHgxNzcxMjc2MjJjNEEwMEYzZDQwOUI3NTU3MWUxMmNCM2M4OTczZDNjIiwiZGVjaW1hbHMiOjE4fSwibmV0d29yayI6IjEwMCJ9XSwidG90YWxTdXBwbHkiOjEyODQ5NDk5NzYsImRlbGVnYXRpb25PdmVycmlkZSI6ZmFsc2V9LCJzcGFjZSI6InRlc3Qud2EweDZlLmV0aCIsIm5ldHdvcmsiOiIxIiwic25hcHNob3QiOiIyMTMwNzAyMCIsImFkZHJlc3NlcyI6WyIweDkxRkQyYzhkMjQ3NjdkYjRFY2U3MDY5QUEyNzgzMmZmYWY4NTkwZjMiXX0.
  2. It should show some positive Voting power for the address
  3. When space is empty, it show 0 VP

@wa0x6e wa0x6e changed the title feat: add space params to strategy playground feat: add space param to strategy playground Dec 1, 2024
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@wa0x6e wa0x6e merged commit bbf46bd into master Dec 2, 2024
7 checks passed
@wa0x6e wa0x6e deleted the feat-add-space-to-playground branch December 2, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants