Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increase vote reason length to 5000 #1079

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat: increase vote reason length to 5000 #1079

merged 2 commits into from
Oct 18, 2024

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Oct 18, 2024

Towards https://github.com/snapshot-labs/workflow/issues/260

Changes proposed in this pull request:

  • Increase Vote's reason max length to 5000.

@Sekhmet Sekhmet requested review from wa0x6e and ChaituVR October 18, 2024 11:25
bonustrack
bonustrack approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ChaituVR ChaituVR merged commit 2c22ba2 into master Oct 18, 2024
4 checks passed
@ChaituVR ChaituVR deleted the sekhmet/increase-vote-reason-limit branch October 18, 2024 12:07
@Sekhmet Sekhmet mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@wa0x6e wa0x6e Awaiting requested review from wa0x6e

@ChaituVR ChaituVR Awaiting requested review from ChaituVR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sekhmet @bonustrack @ChaituVR