Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new privacy type #1082

Merged
merged 7 commits into from
Nov 21, 2024
Merged

feat: Add new privacy type #1082

merged 7 commits into from
Nov 21, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Oct 29, 2024 •
edited
Loading

Towards https://github.com/snapshot-labs/workflow/issues/277

Summary

How to test

  • Run yarn test
  • Try changing values in example.json files

@ChaituVR ChaituVR mentioned this pull request Oct 29, 2024
Merged
ChaituVR
ChaituVR commented Oct 31, 2024
View reviewed changes
src/schemas/space.json Outdated Show resolved Hide resolved
test/examples/space.json Outdated Show resolved Hide resolved
wa0x6e
wa0x6e reviewed Nov 2, 2024
View reviewed changes
src/schemas/space.json Outdated Show resolved Hide resolved
@ChaituVR ChaituVR marked this pull request as draft November 3, 2024 01:44
@ChaituVR ChaituVR marked this pull request as ready for review November 4, 2024 10:38
@ChaituVR ChaituVR requested a review from wa0x6e November 4, 2024 10:38
bonustrack
bonustrack approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

wa0x6e
wa0x6e approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit 23c27a7 into master Nov 21, 2024
4 checks passed
@ChaituVR ChaituVR deleted the add-author-selection-privacy branch November 21, 2024 18:45
ChaituVR added a commit that referenced this pull request Nov 22, 2024
@ChaituVR
Revert "feat: Add new privacy type (#1082)"
f8d9a39 
This reverts commit 23c27a7.
@ChaituVR ChaituVR mentioned this pull request Nov 22, 2024
Merged
ChaituVR added a commit that referenced this pull request Nov 22, 2024
@ChaituVR
Revert "feat: Add new privacy type" (#1085)
5750018 
* Revert "feat: Add new privacy type (#1082)"

This reverts commit 23c27a7.

* Update package.json
@ChaituVR ChaituVR restored the add-author-selection-privacy branch November 27, 2024 05:30
@ChaituVR ChaituVR mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaituVR @wa0x6e @bonustrack