Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix overflowing statement #4943

Merged
merged 3 commits into from
Dec 2, 2024
Merged

fix: fix overflowing statement #4943

merged 3 commits into from
Dec 2, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Dec 1, 2024

Summary

This PR an issue where the statement is overflowing outside the delegation card

Before fix

Screenshot 2024-12-01 at 19 21 30

After fix

Screenshot 2024-12-01 at 19 21 15

How to test

  1. Go to http://localhost:8081/#/paraswap-dao.eth/delegates
  2. The card about jameskbh.eth should not overflow anymore

@wa0x6e wa0x6e requested a review from ChaituVR December 1, 2024 11:23
ChaituVR
ChaituVR approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit 82aaec1 into master Dec 2, 2024
7 checks passed
@wa0x6e wa0x6e deleted the fix-overflowing-statement branch December 2, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR