Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error message when checksum address is expected #4944

Merged
merged 4 commits into from
Dec 2, 2024
Merged

fix: improve error message when checksum address is expected #4944

merged 4 commits into from
Dec 2, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Dec 1, 2024

Summary

This PR improves the error message when a non-checksum address is given in split delegation form

How to test

  1. Go to http://localhost:8081/#/paraswap-dao.eth/delegates?delegate=
  2. Add a new delegation, with a all lowercase address
  3. It should show the error: Must be a valid checksum address.

@wa0x6e wa0x6e requested a review from ChaituVR December 1, 2024 11:49
ChaituVR
ChaituVR approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@wa0x6e wa0x6e merged commit 68231a4 into master Dec 2, 2024
7 checks passed
@wa0x6e wa0x6e deleted the fix-improve-checksum-address-error-message branch December 2, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR