feat: session key authentication

.github/workflows/test.yml

@@ -3,9 +3,9 @@ name: SX-Starknet Workflow
 env:
   STARKNET_SIERRA_COMPILE_PATH: ./cairo/bin/starknet-sierra-compile
   OBJC_DISABLE_INITIALIZE_FORK_SAFETY: YES
-  ADDRESS: "0x347be35996a21f6bf0623e75dbce52baba918ad5ae8d83b6f416045ab22961a"
-  PUBLIC_KEY: "0x674efe292c3c1125108916d6128bd6d1db4528db07322a84177551067aa2bef"
-  PK: "0xbdd640fb06671ad11c80317fa3b1799d"
+  ADDRESS: '0x347be35996a21f6bf0623e75dbce52baba918ad5ae8d83b6f416045ab22961a'
+  PUBLIC_KEY: '0x674efe292c3c1125108916d6128bd6d1db4528db07322a84177551067aa2bef'
+  PK: '0xbdd640fb06671ad11c80317fa3b1799d'
 
 on:
   push:
@@ -116,4 +116,6 @@ jobs:
         run: yarn hardhat starknet-build
 
       - name: run Hardhat tests
-        run: yarn test:l1-execution; yarn test:eth-sig-auth; yarn test:stark-sig-auth;  yarn test:eth-tx-auth
+        run:
+          yarn test:l1-execution; yarn test:eth-sig-auth; yarn test:stark-sig-auth;  yarn test:eth-tx-auth;
+          yarn test:eth-sig-sk-auth; yarn test:stark-sig-sk-auth; yarn test:eth-tx-sk-auth; yarn test:stark-tx-sk-auth

package.json

@@ -16,6 +16,10 @@
     "test:stark-sig-auth": "bash './scripts/stark-sig-auth-test.sh'",
     "test:eth-sig-auth": "bash './scripts/eth-sig-auth-test.sh'",
     "test:eth-tx-auth": "bash './scripts/eth-tx-auth-test.sh'",
+    "test:eth-sig-sk-auth": "bash './scripts/eth-sig-sk-auth-test.sh'",
+    "test:eth-tx-sk-auth": "bash './scripts/eth-tx-sk-auth-test.sh'",
+    "test:stark-sig-sk-auth": "bash './scripts/stark-sig-sk-auth-test.sh'",
+    "test:stark-tx-sk-auth": "bash './scripts/stark-tx-sk-auth-test.sh'",
     "test:l1-execution": "bash './scripts/l1-avatar-execution-test.sh'"
   },
   "devDependencies": {

scripts/eth-sig-sk-auth-test.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+kill -9 $(lsof -t -i:5050)
+yarn chain:l2 &
+sleep 10 &&
+yarn hardhat test tests/eth-sig-sk-auth.test.ts
+if [ $? -eq 0 ]
+then
+  kill -9 $(lsof -t -i:5050)
+  exit 0
+else
+  kill -9 $(lsof -t -i:5050)
+  echo "Tests failed"
+  exit 1
+fi

scripts/eth-tx-sk-auth-test.sh

@@ -0,0 +1,18 @@
+#!/bin/bash
+
+kill -9 $(lsof -t -i:8545)
+kill -9 $(lsof -t -i:5050)
+yarn chain &
+sleep 10 &&
+yarn hardhat test tests/eth-tx-sk-auth.test.ts --network 'ethereumLocal' --starknet-network 'starknetLocal'
+if [ $? -eq 0 ]
+then
+  kill -9 $(lsof -t -i:8545)
+  kill -9 $(lsof -t -i:5050)
+  exit 0
+else
+  kill -9 $(lsof -t -i:8545)
+  kill -9 $(lsof -t -i:5050)
+  echo "Tests failed"
+  exit 1
+fi

scripts/stark-sig-sk-auth-test.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+kill -9 $(lsof -t -i:5050)
+yarn chain:l2 &
+sleep 10 &&
+yarn hardhat test tests/stark-sig-sk-auth.test.ts
+if [ $? -eq 0 ]
+then
+  kill -9 $(lsof -t -i:5050)
+  exit 0
+else
+  kill -9 $(lsof -t -i:5050)
+  echo "Tests failed"
+  exit 1
+fi

scripts/stark-tx-sk-auth-test.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+kill -9 $(lsof -t -i:5050)
+yarn chain:l2 &
+sleep 10 &&
+yarn hardhat test tests/stark-tx-sk-auth.test.ts
+if [ $? -eq 0 ]
+then
+  kill -9 $(lsof -t -i:5050)
+  exit 0
+else
+  kill -9 $(lsof -t -i:5050)
+  echo "Tests failed"
+  exit 1
+fi

starknet/Scarb.lock

@@ -0,0 +1,14 @@
+# Code generated by scarb DO NOT EDIT.
+version = 1
+
+[[package]]
+name = "openzeppelin"
+version = "0.7.0-rc.0"
+source = "git+https://github.com/snapshot-labs/openzeppelin-cairo-contracts.git?branch=feat%2Ferc20votes-%23631-frozen#e9d17922f938cc62c7dabaf13d700e7290b7c274"
+
+[[package]]
+name = "sx"
+version = "0.1.0"
+dependencies = [
+ "openzeppelin",
+]

starknet/src/authenticators/eth_sig_session_key.cairo

@@ -0,0 +1,211 @@
+use starknet::{ContractAddress, EthAddress};
+use sx::types::{Strategy, IndexedStrategy, Choice};
+
+#[starknet::interface]
+trait IEthSigSessionKeyAuthenticator<TContractState> {
+    fn authenticate_propose(
+        ref self: TContractState,
+        signature: Array<felt252>,
+        space: ContractAddress,
+        author: EthAddress,
+        metadata_uri: Array<felt252>,
+        execution_strategy: Strategy,
+        user_proposal_validation_params: Array<felt252>,
+        salt: felt252,
+        session_public_key: felt252
+    );
+
+    fn authenticate_vote(
+        ref self: TContractState,
+        signature: Array<felt252>,
+        space: ContractAddress,
+        voter: EthAddress,
+        proposal_id: u256,
+        choice: Choice,
+        user_voting_strategies: Array<IndexedStrategy>,
+        metadata_uri: Array<felt252>,
+        session_public_key: felt252
+    );
+
+    fn authenticate_update_proposal(
+        ref self: TContractState,
+        signature: Array<felt252>,
+        space: ContractAddress,
+        author: EthAddress,
+        proposal_id: u256,
+        execution_strategy: Strategy,
+        metadata_uri: Array<felt252>,
+        salt: felt252,
+        session_public_key: felt252
+    );
+
+    fn register_with_owner_sig(
+        ref self: TContractState,
+        r: u256,
+        s: u256,
+        v: u32,
+        owner: EthAddress,
+        session_public_key: felt252,
+        session_duration: u32,
+        salt: u256,
+    );
+
+    fn revoke_with_owner_sig(
+        ref self: TContractState,
+        r: u256,
+        s: u256,
+        v: u32,
+        owner: EthAddress,
+        session_public_key: felt252,
+        salt: u256,
+    );
+
+    fn revoke_with_session_key_sig(
+        ref self: TContractState,
+        signature: Array<felt252>,
+        owner: EthAddress,
+        session_public_key: felt252,
+        salt: felt252
+    );
+}
+
+#[starknet::contract]
+mod EthSigSessionKeyAuthenticator {
+    use super::IEthSigSessionKeyAuthenticator;
+    use starknet::{ContractAddress, EthAddress};
+    use sx::interfaces::{ISpaceDispatcher, ISpaceDispatcherTrait};
+    use sx::types::{Strategy, IndexedStrategy, Choice, UserAddress};
+    use sx::utils::{EIP712, SessionKey, LegacyHashEthAddress, LegacyHashUsedSalts, ByteReverse};
+
+    #[storage]
+    struct Storage {}
+
+    #[external(v0)]
+    impl EthSigSessionKeyAuthenticator of IEthSigSessionKeyAuthenticator<ContractState> {
+        fn authenticate_propose(
+            ref self: ContractState,
+            signature: Array<felt252>,
+            space: ContractAddress,
+            author: EthAddress,
+            metadata_uri: Array<felt252>,
+            execution_strategy: Strategy,
+            user_proposal_validation_params: Array<felt252>,
+            salt: felt252,
+            session_public_key: felt252
+        ) {
+            let mut state = SessionKey::unsafe_new_contract_state();
+            SessionKey::InternalImpl::authenticate_propose(
+                ref state,
+                signature,
+                space,
+                UserAddress::Ethereum(author),
+                metadata_uri,
+                execution_strategy,
+                user_proposal_validation_params,
+                salt,
+                session_public_key
+            );
+        }
+
+        fn authenticate_vote(
+            ref self: ContractState,
+            signature: Array<felt252>,
+            space: ContractAddress,
+            voter: EthAddress,
+            proposal_id: u256,
+            choice: Choice,
+            user_voting_strategies: Array<IndexedStrategy>,
+            metadata_uri: Array<felt252>,
+            session_public_key: felt252
+        ) {
+            let mut state = SessionKey::unsafe_new_contract_state();
+            SessionKey::InternalImpl::authenticate_vote(
+                ref state,
+                signature,
+                space,
+                UserAddress::Ethereum(voter),
+                proposal_id,
+                choice,
+                user_voting_strategies,
+                metadata_uri,
+                session_public_key
+            );
+        }
+
+        fn authenticate_update_proposal(
+            ref self: ContractState,
+            signature: Array<felt252>,
+            space: ContractAddress,
+            author: EthAddress,
+            proposal_id: u256,
+            execution_strategy: Strategy,
+            metadata_uri: Array<felt252>,
+            salt: felt252,
+            session_public_key: felt252
+        ) {
+            let mut state = SessionKey::unsafe_new_contract_state();
+            SessionKey::InternalImpl::authenticate_update_proposal(
+                ref state,
+                signature,
+                space,
+                UserAddress::Ethereum(author),
+                proposal_id,
+                execution_strategy,
+                metadata_uri,
+                salt,
+                session_public_key
+            );
+        }
+
+
+        fn register_with_owner_sig(
+            ref self: ContractState,
+            r: u256,
+            s: u256,
+            v: u32,
+            owner: EthAddress,
+            session_public_key: felt252,
+            session_duration: u32,
+            salt: u256,
+        ) {
+            let mut state = SessionKey::unsafe_new_contract_state();
+            SessionKey::InternalImpl::register_with_owner_eth_sig(
+                ref state, r, s, v, owner, session_public_key, session_duration, salt
+            );
+        }
+
+        fn revoke_with_owner_sig(
+            ref self: ContractState,
+            r: u256,
+            s: u256,
+            v: u32,
+            owner: EthAddress,
+            session_public_key: felt252,
+            salt: u256,
+        ) {
+            let mut state = SessionKey::unsafe_new_contract_state();
+            SessionKey::InternalImpl::revoke_with_owner_eth_sig(
+                ref state, r, s, v, owner, session_public_key, salt
+            );
+        }
+
+        fn revoke_with_session_key_sig(
+            ref self: ContractState,
+            signature: Array<felt252>,
+            owner: EthAddress,
+            session_public_key: felt252,
+            salt: felt252
+        ) {
+            let mut state = SessionKey::unsafe_new_contract_state();
+            SessionKey::InternalImpl::revoke_with_session_key_sig(
+                ref state, signature, UserAddress::Ethereum(owner), session_public_key, salt
+            );
+        }
+    }
+
+    #[constructor]
+    fn constructor(ref self: ContractState, name: felt252, version: felt252,) {
+        let mut state = SessionKey::unsafe_new_contract_state();
+        SessionKey::InternalImpl::eth_sig_initializer(ref state, name, version);
+    }
+}