422 issue nullpointerexception when starting a test with a key schema file serializer config #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and other Serializers.
…ng-a-test-with-a-key-schema-file-serializer-config # Conflicts: # src/main/java/com/sngular/kloadgen/sampler/KafkaProducerSampler.java
…eSerializer to KeyFileSerializer.
Closed
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This pull request hasn't been labeled as |
…ng-a-test-with-a-key-schema-file-serializer-config
…ng-a-test-with-a-key-schema-file-serializer-config
jemacineiras
requested changes
Dec 11, 2023
|
|
||
| import org.apache.kafka.common.serialization.Serializer; | ||
|
|
||
| public interface EnrichedRecordSerializer<T extends EnrichedRecord> extends Serializer<T> { |
There was a problem hiding this comment.
There is no sense on that. Rethink.
There was a problem hiding this comment.
This is a tag for those serializers that can accept a EnricherdRecord, instead of a GenericRecordSerializer. Is there a way to query this programatically?
| @@ -0,0 +1,21 @@ | |||
| package com.sngular.kloadgen.serializer; | |||
There was a problem hiding this comment.
I think is is not needed.
There was a problem hiding this comment.
I don't understand. Isn't the package line always needed for classes?
jemacineiras
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.