Fix user-module import #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I need to test this out and verify things are working as expected with the rest of the system. |
|
Any ETA on this ? @jakehamilton i think this would be cool if this can be checked since many issues are concerning problems about applying home manager configuration. Personally, i use this and this fixed my issues with home manager not loading |
|
@AurelienConte thanks for the reminder! I will test it today and try to get things merged in if there aren't any issues :) |
jakehamilton
requested changes
Oct 28, 2024
| config = builtins.removeAttrs home-config ["imports"]; | ||
| }); | ||
|
|
||
| sharedModules = optional config.snowfallorg.users.${user-name}.home.enable user-module; |
There was a problem hiding this comment.
This will include the user-specific module for all home-manager users. I don't think we can use this solution since it would break multi-user setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue with user-module import, which is
home-manager.users.${user}are set properly, butsnowfallorg.users.${user}.home.configaren't.This is a fix for it.
related: #104