Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1526335: support OCSP FAIL_OPEN #740

Merged
merged 8 commits into from
Oct 16, 2024
Merged

SNOW-1526335: support OCSP FAIL_OPEN #740

merged 8 commits into from
Oct 16, 2024

Conversation

sfc-gh-ext-simba-hx
Copy link
Collaborator

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx commented Aug 20, 2024 •
edited
Loading

teamwork issue 1039

Add new boolean connection attribute SF_CON_OCSP_FAIL_OPEN. Can be set/get through existing APIs snowflake_set_attribute() and snowflake_get_attribute().
Possible values are SF_BOOLEAN_TRUE and SF_BOOLEAN_FALSE. The default values is SF_BOOLEAN_FALSE. When it's set to SF_BOOLEAN_TRUE ocsp validation will take fail-open behavior and fail-close when it's SF_BOOLEAN_FALSE. The behavior details are documented here https://docs.snowflake.com/en/user-guide/ocsp#fail-open-or-fail-close-behavior

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx requested a review from a team as a code owner August 20, 2024 23:38
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx changed the base branch from master to master-2.0.0 October 3, 2024 16:51
sfc-gh-dprzybysz
sfc-gh-dprzybysz approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the problem is the default value then we can keep the old default FAIL_CLOSED and as part of the next major release just change the default value
it would allow merging the change even now to master

sfc-gh-dprzybysz
sfc-gh-dprzybysz requested changes Oct 9, 2024
View reviewed changes
lib/client.c Show resolved Hide resolved
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx changed the base branch from master-2.0.0 to master October 10, 2024 21:43
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx merged commit 0ab3ba8 into master Oct 16, 2024
43 checks passed
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx deleted the SNOW-1526335-ocsp-fail-open branch October 16, 2024 21:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski Awaiting requested review from sfc-gh-jszczerbinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-ext-simba-hx @sfc-gh-dprzybysz @sfc-gh-dstempniak