SNOW-1874056: Support vs17 (#412)

Co-authored-by: Dominik Przybysz <[email protected]>

.github/workflows/build_test.yml

@@ -26,10 +26,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        # have to specify minor version on windows
+        # have to specify patch version on windows
         # otherwise could get version mismatch issue when running test on github
         # need to keep track on the latest version
-        php-version: ['8.1.31', '8.2.26', '8.3.14', '8.4.1']
+        php-version: ['8.1.31', '8.2.27', '8.3.16', '8.4.3']
     # The type of runner that the job will run on
     runs-on: windows-2019
     env:
@@ -58,6 +58,42 @@ jobs:
         run: python .\.github\workflows\scripts\test_driver.py
         shell: cmd
 
+  build_test_windows-vs2022:
+    strategy:
+      fail-fast: false
+      matrix:
+        # have to specify patch version on windows
+        # otherwise could get version mismatch issue when running test on github
+        # need to keep track on the latest version
+        php-version: ['8.4.3']
+    # The type of runner that the job will run on
+    runs-on: windows-2022
+    env:
+      ARCH: x64
+      TARGET: Release
+      VS: VS17
+      PHP: ${{ matrix.php-version }}
+      TEST_PHP_EXECUTABLE: c:\tools\php\php.exe
+    # Steps represent a sequence of tasks that will be executed as part of the job
+    steps:
+      - uses: actions/checkout@v4
+      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+      - name: setup php
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-version }}
+          extensions: pdo, json
+        env:
+          phpts: ts
+
+      - name: build driver
+        run: python .\.github\workflows\scripts\build_driver.py
+        shell: cmd
+
+      - name: test driver
+        run: python .\.github\workflows\scripts\test_driver.py
+        shell: cmd
+
   build_test_linux:
     strategy:
       fail-fast: false

README.rst

@@ -94,7 +94,7 @@ Building the Driver on Windows
 
 **Note**: Snowflake supports only thread-safe versions of PHP.
 
-You must install Microsoft Visual Studio 2019 (VS16) with the C++ development installer option.
+You must install Microsoft Visual Studio 2019 (VS16) or 2022 (VS17) with the C++ development installer option.
 
 To build the PHP driver for Windows:
 
@@ -131,7 +131,7 @@ To build the PHP driver for Windows:
 
    - :code:`<arch>` is your CPU architecture (Currently, the driver only supports :code:`x64`).
    - :code:`<build>` is the type of binary that you want to build (:code:`Release` or :code:`Debug`).
-   - :code:`<visual studio version>` is the version of Visual Studio that you are using (Currently, the driver only supports :code:`VS16`).
+   - :code:`<visual studio version>` is the version of Visual Studio that you are using (Currently, the driver only supports :code:`VS16` and :code:`VS17`).
    - :code:`<path to PHP SDK>` is the path to the directory where the PHP SDK should be downloaded.
      **Do not create this directory.** The script creates this directory for you when downloading the PHP SDK.
 
@@ -573,7 +573,7 @@ To run the tests, do the following:
 where:
 
 - :code:`<arch>` is your CPU architecture (Currently :code:`x64` is the only supported one).
-- :code:`<visual studio version>` is the version of Visual Studio that you are using (Currently :code:`VS16` is the only supported one).
+- :code:`<visual studio version>` is the version of Visual Studio that you are using (Currently :code:`VS16` and :code:`VS17` are supported).
 - :code:`<path to PHP SDK>` is the path to the directory where the PHP SDK should be downloaded.
 
 Additional Notes