Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1821509: add ocsp options #407

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-ext-simba-hx
Copy link
Collaborator

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx commented Dec 13, 2024

teamwork issue 1180
Will have libsfclient 2.0 update in separated PR

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx requested a review from a team as a code owner December 13, 2024 17:52
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx marked this pull request as draft December 13, 2024 17:53
@sfc-gh-dprzybysz
Copy link
Collaborator

before making ready for review please split into smaller PRs - one for upgrade, one for adding vs17 support and for new OCSP option

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx force-pushed the SNOW-1821509-OCSP-disable-option branch from 2cf93c1 to 9e7e92f Compare January 22, 2025 00:50
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx marked this pull request as ready for review January 22, 2025 00:53
@@ -101,5 +101,7 @@ enum {
#define PDO_SNOWFLAKE_CONN_ATTR_LOGIN_TIMEOUT_IDX 19
#define PDO_SNOWFLAKE_CONN_ATTR_MAX_RETRIES_IDX 20
#define PDO_SNOWFLAKE_CONN_ATTR_RETRY_TIMEOUT_IDX 21
#define PDO_SNOWFLAKE_CONN_ATTR_OCSP_FAIL_OPEN_IDX 22
#define PDO_SNOWFLAKE_CONN_ATTR_OCSP_DISABLE 23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing _IDX suffix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants