Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1874056: support vs17 #412

Merged
merged 4 commits into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ jobs:
strategy:
fail-fast: false
matrix:
# have to specify minor version on windows
# have to specify patch version on windows
# otherwise could get version mismatch issue when running test on github
# need to keep track on the latest version
php-version: ['8.1.31', '8.2.26', '8.3.14', '8.4.1']
php-version: ['8.1.31', '8.2.27', '8.3.16', '8.4.3']
# The type of runner that the job will run on
runs-on: windows-2019
env:
Expand Down Expand Up @@ -58,6 +58,42 @@ jobs:
run: python .\.github\workflows\scripts\test_driver.py
shell: cmd

build_test_windows-vs2022:
strategy:
fail-fast: false
matrix:
# have to specify patch version on windows
# otherwise could get version mismatch issue when running test on github
# need to keep track on the latest version
php-version: ['8.4.3']
# The type of runner that the job will run on
runs-on: windows-2022
env:
ARCH: x64
TARGET: Release
VS: VS17
PHP: ${{ matrix.php-version }}
TEST_PHP_EXECUTABLE: c:\tools\php\php.exe
# Steps represent a sequence of tasks that will be executed as part of the job
steps:
- uses: actions/checkout@v4
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- name: setup php
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
extensions: pdo, json
env:
phpts: ts

- name: build driver
run: python .\.github\workflows\scripts\build_driver.py
shell: cmd

- name: test driver
run: python .\.github\workflows\scripts\test_driver.py
shell: cmd

build_test_linux:
strategy:
fail-fast: false
Expand Down
Loading
Loading