Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1821509: update libsfclient 2.0.0 #413

Merged
merged 9 commits into from
Feb 7, 2025

Conversation

sfc-gh-ext-simba-hx
Copy link
Collaborator

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx commented Jan 29, 2025

teamwork issue 1180: update libsfclient to 2.0.0 for OCSP changes.
SNOW-710393: put get support. Added test cases as well.
side changes:

  • remove PHP 8.4 test with vs16 since PHP 8.4 on github hosted runner is built with vs17.
  • add test cases for multiple statements as unsupported query. (test case only no driver changes as the feature is blocked on server side)

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx requested a review from a team as a code owner January 29, 2025 03:13
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx force-pushed the SNOW-1821509-update-libsfclient-2.0 branch 2 times, most recently from 0ae9f92 to caa5bb2 Compare January 29, 2025 05:51
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (53edf0f) to head (aadf26e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
- Coverage   86.88%   86.46%   -0.43%     
==========================================
  Files           7        7              
  Lines         938      938              
  Branches      118      118              
==========================================
- Hits          815      811       -4     
- Misses        123      127       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx force-pushed the SNOW-1821509-update-libsfclient-2.0 branch 2 times, most recently from 431baec to 8de8330 Compare January 30, 2025 19:31
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx force-pushed the SNOW-1821509-update-libsfclient-2.0 branch from 8456c59 to b89bcc3 Compare January 31, 2025 21:04
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for official libsfclient 2.0.0 release and then update the binaries

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 1141014 into master Feb 7, 2025
17 of 18 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1821509-update-libsfclient-2.0 branch February 7, 2025 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants