Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1949003: Skip test until Snowflake 9.4 release #2185

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

sfc-gh-pbulawa
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1949003

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Skip test of a new functionality that is not yet released.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-pbulawa sfc-gh-pbulawa added DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md labels Feb 25, 2025
Copy link
Contributor

@sfc-gh-mkubik sfc-gh-mkubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just fix the olddriver (by reordering annotations I guess?)

@@ -481,6 +481,47 @@ def test_struct_time(conn, db_parameters):
time.tzset()


@pytest.mark.skip(reason="Skip until Snowflake 9.4 is released") # TODO: SNOW-1949054

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason the whole test's been moved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a mistake, fixed.

@sfc-gh-pbulawa sfc-gh-pbulawa changed the title SNOW-1949003: Skip test until 9.4 release is released SNOW-1949003: Skip test until Snowflake 9.4 release Feb 25, 2025
@sfc-gh-mmishchenko sfc-gh-mmishchenko merged commit 900a676 into main Feb 25, 2025
92 of 93 checks passed
@sfc-gh-mmishchenko sfc-gh-mmishchenko deleted the SNOW-1949003 branch February 25, 2025 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants