Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up jackson core and databind libraries #63

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

sfc-gh-japatel
Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel commented Oct 7, 2020

SNOW-202934

Getting ClassNotFoundException: net.snowflake.ingest.internal.fasterxml.jackson.core.exc.InputCoercionException
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
... 17 more

There was an automatic bump up by dependabot. FasterXML/jackson-databind#2511

We need to release this version as well. Will follow up after this change.

Test: https://travis-ci.org/github/snowflakedb/snowflake-ingest-java/builds/733753169

@codecov-io
Copy link

Codecov Report

Merging #63 into master will increase coverage by 8.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   22.19%   30.88%   +8.68%     
==========================================
  Files          17       17              
  Lines         829      829              
  Branches       45       45              
==========================================
+ Hits          184      256      +72     
+ Misses        625      548      -77     
- Partials       20       25       +5     
Impacted Files Coverage Δ
...lake/ingest/connection/ServiceResponseHandler.java 22.44% <0.00%> (+8.16%) ⬆️
...et/snowflake/ingest/connection/RequestBuilder.java 58.77% <0.00%> (+8.77%) ⬆️
...java/net/snowflake/ingest/SimpleIngestManager.java 38.46% <0.00%> (+8.97%) ⬆️
.../net/snowflake/ingest/connection/IngestStatus.java 34.61% <0.00%> (+34.61%) ⬆️
...et/snowflake/ingest/connection/IngestResponse.java 40.00% <0.00%> (+40.00%) ⬆️
...t/snowflake/ingest/connection/HistoryResponse.java 41.66% <0.00%> (+41.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a94c3...c6854af. Read the comment docs.

Copy link

@sfc-gh-jliang sfc-gh-jliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-japatel sfc-gh-japatel merged commit 7913ff8 into master Oct 7, 2020
sfc-gh-tzhang added a commit that referenced this pull request Jan 12, 2022
1. Improve logging to debug OOM issue
2. Looks like we do have a loader/unloader for arrow vectors, use that instead of writing our own logic since it does more things, and it fixes the IndexOutOfBoundException as well
3. Collect row count in perf metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants