SNOW-1553624 - structured types bindings test all types #1841
+1,597
−285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ErrorCode.FEATURE_UNSUPPORTED, | ||
| "Can't construct array for data type: " + columnSubType); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
can we inverse the condition and skip then else to make less changes here?
src/main/java/net/snowflake/client/core/arrow/MapConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakePreparedStatementV1.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/jdbc/BindingAndInsertingArraysStructuredTypesLatestIT.java
Outdated
Show resolved
Hide resolved
| public Connection init() throws SQLException { | ||
| Connection conn = BaseJDBCTest.getConnection(BaseJDBCTest.DONT_INJECT_SOCKET_TIMEOUT); | ||
| try (Statement stmt = conn.createStatement()) { | ||
| stmt.execute("alter session set ENABLE_STRUCTURED_TYPES_IN_CLIENT_RESPONSE = true"); |
There was a problem hiding this comment.
could we change the alter session to update all parameters in one call?
| stmt.executeUpdate(); | ||
|
|
||
| try (ResultSet resultSet = statement.executeQuery("SELECT * from array_of_varchars"); ) { | ||
| resultSet.next(); |
There was a problem hiding this comment.
let's wrap next calls with assertTrue
src/test/java/net/snowflake/client/jdbc/BindingAndInsertingArraysStructuredTypesLatestIT.java
Outdated
Show resolved
Hide resolved
sfc-gh-pmotacki
force-pushed
the
structured_types_binding
branch
from
6f9c168
to
39b7927
Compare
sfc-gh-pmotacki
force-pushed
the
structured_types_binding
branch
from
39b7927
to
5631aa7
Compare
sfc-gh-pmotacki
force-pushed
the
structured_types_binding
branch
from
14ddc4e
to
ae00e43
Compare
| * statement; if a database access error occurs or this method is called on a closed <code> | ||
| * PreparedStatement</code> | ||
| * @throws SQLFeatureNotSupportedException if the JDBC driver does not support this method | ||
| * @since 1.2 |
There was a problem hiding this comment.
is it copied from the JDBC docs? we should validate that since the info here may be misleading
| /** | ||
| * Sets the designated parameter to the given Map instance. | ||
| * | ||
| * @param parameterIndex |
There was a problem hiding this comment.
let's add some description for the parameters
sfc-gh-pmotacki
changed the title
sfc-gh-pmotacki
force-pushed
the
structured_types_binding
branch
from
0ed5b76
to
e50d465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1553624
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.