SNOW-1731124 Arrow batches fields #1925
Open
+305
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-types # Conflicts: # src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/SimpleArrowFullVectorConverter.java
…e-types # Conflicts: # src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverter.java # src/main/java/net/snowflake/client/jdbc/ArrowResultChunk.java
…stamps # Conflicts: # src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverter.java
# Conflicts: # src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverterUtil.java # src/main/java/net/snowflake/client/jdbc/ArrowResultChunk.java # src/test/java/net/snowflake/client/jdbc/ArrowBatchesIT.java
# Conflicts: # src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverterUtil.java # src/main/java/net/snowflake/client/jdbc/ArrowResultChunk.java # src/test/java/net/snowflake/client/jdbc/ArrowBatchesIT.java
| @@ -58,8 +65,7 @@ protected FieldVector convertVector() | |||
| FieldVector convertedDataVector = | |||
| ArrowFullVectorConverterUtil.convert( | |||
| allocator, dataVector, context, session, timeZoneToUse, 0, valueTargetType); | |||
| // TODO: change to convertedDataVector and make all necessary changes to make it work | |||
| ListVector convertedListVector = initVector(vector.getName(), dataVector.getField()); | |||
| ListVector convertedListVector = initVector(vector.getName(), convertedDataVector.getField()); | |||
There was a problem hiding this comment.
This is the line that required the whole change - if we don't keep nullability properly, mapVector will complain about it's grandchildren being nullable. As the grandchildren may be of any type, all converters were affected.
There was a problem hiding this comment.
let's add some tests to show the improvement
There was a problem hiding this comment.
Added a unit test checking if FieldTypes behave as expected when converting a MapVector
src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/VarCharVectorConverter.java
Show resolved
Hide resolved
| @@ -58,8 +65,7 @@ protected FieldVector convertVector() | |||
| FieldVector convertedDataVector = | |||
| ArrowFullVectorConverterUtil.convert( | |||
| allocator, dataVector, context, session, timeZoneToUse, 0, valueTargetType); | |||
| // TODO: change to convertedDataVector and make all necessary changes to make it work | |||
| ListVector convertedListVector = initVector(vector.getName(), dataVector.getField()); | |||
| ListVector convertedListVector = initVector(vector.getName(), convertedDataVector.getField()); | |||
There was a problem hiding this comment.
let's add some tests to show the improvement
sfc-gh-pbulawa
approved these changes
Oct 22, 2024
sfc-gh-astachowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added creation of Fields matching original vectors' fields. This concerns mainly nullability of vectors.