SNOW-1812949 add get object and get bytes support for native arrow structured types #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat ARROW is set
…, add variant test case
sfc-gh-pmotacki
approved these changes
Nov 20, 2024
sfc-gh-pmotacki
requested changes
Nov 20, 2024
| return createJsonSqlInput(columnIndex, obj); | ||
| } else if (converter instanceof StructConverter) { | ||
| return createArrowSqlInput(columnIndex, (Map<String, Object>) obj); | ||
| if (type == Types.STRUCT && isStructuredType && converter instanceof VarCharConverter) { |
There was a problem hiding this comment.
Could we extract these conditions?
| return text; | ||
| } | ||
|
|
||
| private static String buildJsonStringFromElements(Object elements) throws SQLException { | ||
| try { | ||
| return SnowflakeUtil.mapJson(elements); |
There was a problem hiding this comment.
Here, we create JSON using ObjectMapper. Shouldn't it be created by our types mappers?
| private int baseType; | ||
| private Object elements; | ||
|
|
||
| public SfSqlArray(String text, int baseType, Object elements) { |
There was a problem hiding this comment.
- can we reuse new constructor in other constructors?
- can we remove other constructors?
| @@ -0,0 +1,22 @@ | |||
| package net.snowflake.client.core.arrow; | |||
There was a problem hiding this comment.
please add license header
| public void testRunAsGetString() throws SQLException { | ||
| withFirstRow( | ||
| connections.get(queryResultFormat), | ||
| selectSql, | ||
| (resultSet) -> assertGetStringIsCompatible(resultSet, expectedStructureTypeRepresentation)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testRunAsGetObject() throws SQLException { |
There was a problem hiding this comment.
we are fetching and getting the same data for Object and Bytes - can we run bot (or even more tests) on the same result set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getObject and getBytes implementations for native arrow structured types
SNOW-1812949
The getString unification was already introduced to JDBC driver. This PR introduces changes for getObject and getBytes functions:
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX: