Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr 387 #393

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Test pr 387 #393

wants to merge 2 commits into from

Conversation

sfc-gh-aling
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@codecov-commenter
Copy link

Codecov Report

Merging #393 (3fabab5) into main (13f543d) will increase coverage by 0.46%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   80.86%   81.33%   +0.46%     
==========================================
  Files           9       10       +1     
  Lines        1265     1270       +5     
  Branches      189      190       +1     
==========================================
+ Hits         1023     1033      +10     
+ Misses        181      174       -7     
- Partials       61       63       +2     
Impacted Files Coverage Δ
src/snowflake/sqlalchemy/snowdialect.py 78.12% <50.00%> (+0.25%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants