Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accepting query_tag as session_parameters in connection arguments #496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NehaNRane
Copy link

@NehaNRane NehaNRane commented Apr 26, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1348391: Unable to use query_tag in Snowflake-SQLAlchemy #495

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.
    The solution involves integrating the query_tag parameter into the session_parameters dictionary. This dictionary is part of the connection arguments used when establishing a connection to Snowflake through SQLAlchemy. By including query_tag in session_parameters, users can specify a custom query tag to be associated with their queries.

If the user does not explicitly provide a query_tag, the library will revert to its current behavior. In this case, no query tag will be attached to the executed queries. This ensures backward compatibility with existing codebases and prevents any unintended changes in behavior for users who do not wish to utilize the query_tag functionality.

If the user provides a query_tag in the session_parameters dictionary, the library will extract it and set it in the queries being executed against Snowflake. This allows users to dynamically specify custom query tags based on their requirements.

@NehaNRane NehaNRane requested a review from a team as a code owner April 26, 2024 15:44
Copy link

github-actions bot commented Apr 26, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@NehaNRane
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1348391: Unable to use query_tag in Snowflake-SQLAlchemy
1 participant