Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
It seemed silly to create an issue for something that's not typically a practical problem. But if this line is hit as is, you get
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
The originally referenced NULLTYPE is already an instance of
NullType
, so when the code goes to instantiate it, it fails. I imagine this code path is not currently tested then...but it's not obvious to me how to go about adding any tests that depend on the connection like this function. Or at the very least, writing such a test without your test infrastructure would seem to be challenging.