modified comments and test cases

snowflakedb · Aug 20, 2024 · 3179e0b · 3179e0b
1 parent bdf0ba9
commit 3179e0b
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 33 deletions.
diff --git a/src/main/java/com/snowflake/snowpark_java/Functions.java b/src/main/java/com/snowflake/snowpark_java/Functions.java
@@ -3925,18 +3925,6 @@ public static Column isnull(Column c) {
     return new Column(com.snowflake.snowpark.functions.isnull(c.toScalaColumn()));
   }
 
-  /**
-   * Wrapper for Snowflake built-in conv function. Convert number with from and to base.
-   *
-   * @since 1.14.0
-   * @param c Column to be converted.
-   * @param fromBase Column from base format.
-   * @param toBase Column to base format.
-   * @return Column object.
-   */
-  public static Column conv(Column c, Integer fromBase, Integer toBase) {
-    return new Column(com.snowflake.snowpark.functions.conv(c.toScalaColumn(), fromBase, toBase));
-  }
   /**
    * Returns the current Unix timestamp (in seconds) as a long. Extracts a specified date or time
    * portion from a date, time, or timestamp. All calls of `unix_timestamp` within the same query

diff --git a/src/main/scala/com/snowflake/snowpark/functions.scala b/src/main/scala/com/snowflake/snowpark/functions.scala
@@ -3176,17 +3176,6 @@ object functions {
    */
   def isnull(c: Column): Column = is_null(c)
 
-  /**
-   * Wrapper for Snowflake built-in conv function. Convert number with from and to base.
-   * @since 1.14.0
-   * @param c Column to be converted.
-   * @param fromBase Column from base format.
-   * @param toBase Column to base format.
-   * @return Column object.
-   */
-  def conv(c: Column, fromBase: Int, toBase: Int): Column =
-    callBuiltin("conv", c, fromBase, toBase)
-
   /**
    * Returns the current Unix timestamp (in seconds) as a long.
    * Extracts a specified date or time portion from a date, time, or timestamp.

diff --git a/src/test/java/com/snowflake/snowpark_test/JavaFunctionSuite.java b/src/test/java/com/snowflake/snowpark_test/JavaFunctionSuite.java
@@ -2778,11 +2778,6 @@ public void isnull() {
     checkAnswer(df.select(Functions.isnull(df.col("a"))), expected, false);
   }
 
-  public void conv() {
-    DataFrame df = getSession().sql("select * from values('010101') as t(a)");
-    checkAnswer(df.select(Functions.conv(df.col("a"), 2, 16)), new Row[] {Row.create("15")}, false);
-  }
-
   public void unix_timestamp() {
     DataFrame df =
         getSession().sql("select * from values('2024-04-08T23:39:20.123-07:00') as t(a)");

diff --git a/src/test/scala/com/snowflake/snowpark_test/FunctionSuite.scala b/src/test/scala/com/snowflake/snowpark_test/FunctionSuite.scala
@@ -2185,12 +2185,9 @@ trait FunctionSuite extends TestData {
 
   test("isnull") {
     val data = Seq("1", null).toDF("a")
-    checkAnswer(data.select(isnull(col("a"))), Seq(Row(true, false)), sort = false)
-  }
-  test("conv") {
-    val data = Seq("010101").toDF("a")
-    checkAnswer(data.select(conv(col("a"), 2, 16)), Seq(Row("15")), sort = false)
+    checkAnswer(data.select(isnull(col("a"))), Seq(Row(true), Row(false)), sort = false)
   }
+
   test("unix_timestamp") {
     val data = Seq("2024-04-08T23:39:20.123-07:00").toDF("a")
     checkAnswer(data.select(unix_timestamp(col("a"))), Seq(Row("1712619560123")), sort = false)