Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-970028 Update license info in POM #63

Merged
merged 2 commits into from
Nov 15, 2023
Merged

SNOW-970028 Update license info in POM #63

merged 2 commits into from
Nov 15, 2023

Conversation

sfc-gh-bli
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Replace this with a short description of how your code change solves the related issue.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

Replace placeholder value with Snowflake Computing copyright.
Copy link
Collaborator

@sfc-gh-jfreeberg sfc-gh-jfreeberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Good catch.

I changed one line, the license file itself had a boilerplate that should have been replaced with our company's name, like this: https://github.com/snowflakedb/snowpark-python/blob/main/LICENSE.txt#L190

@sfc-gh-bli sfc-gh-bli enabled auto-merge (squash) November 15, 2023 21:20
@sfc-gh-bli sfc-gh-bli merged commit 14b3e82 into main Nov 15, 2023
13 checks passed
@sfc-gh-bli sfc-gh-bli deleted the snow-970028 branch November 15, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants