-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1720855: clean up multithreading changes after rollout #2658
Draft
sfc-gh-aalam
wants to merge
7
commits into
main
Choose a base branch
from
aalam-SNOW-1720855-clean-up-multithreading-changes-after-rollout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
SNOW-1720855: clean up multithreading changes after rollout #2658
sfc-gh-aalam
wants to merge
7
commits into
main
from
aalam-SNOW-1720855-clean-up-multithreading-changes-after-rollout
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aalam
added
the
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
label
Nov 20, 2024
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
…hanges-after-rollout
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
…hanges-after-rollout
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
local testing
Local Testing issues/PRs
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1720855
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Clean-up code by removing param protection and remove tests that test the case when thread-safe session is disabled.