SNOW-1787415 Fix UDF, UDAF, sproc functions with registered object_name for execution replay #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-evandenberg
requested review from
sfc-gh-jdu,
sfc-gh-yuwang and
sfc-gh-jrose
and removed request for
a team
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
1 similar comment
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
|
Looks good! Went over and left some comments. There's also a good number of gates failing atm, we should definitely ensure they're all green before merging this back. |
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-evandenberg
force-pushed
the
evandenberg-SNOW-1787415-fix-udf-udaf-sproc-functions-with-registered-object-name-3
branch
from
ed33399 to
f13bdbf
Compare
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-evandenberg
changed the base branch from
ls-SNOW-1491199-merge-phase0-server-side
to
ls-SNOW-1491199-merge-phase0
sfc-gh-evandenberg
requested review from
sfc-gh-azhan and
sfc-gh-rdurrani
and removed request for
a team
sfc-gh-evandenberg
changed the base branch from
ls-SNOW-1491199-merge-phase0
to
ls-SNOW-1491199-merge-phase0-server-side
sfc-gh-yuwang
deleted the
evandenberg-SNOW-1787415-fix-udf-udaf-sproc-functions-with-registered-object-name-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.