-
Notifications
You must be signed in to change notification settings - Fork 443
Add znode import and export support. #210
base: master
Are you sure you want to change the base?
Add znode import and export support. #210
Conversation
Hi @adrianluisgonzalez , thank you for the contribution. Unfortunately we are not yet ready to upgrade to guava 14 for exhibitor yet, are you able to rework your pull with the current guava version (11)? Thanks. |
45b9635
to
6e4848f
Compare
Hi @qiangdavidliu, the commit has been updated. Let me know if you have any other feedback. |
I'll try to get to this soon. Thanks for your patience. |
Hi @Randgalt, just wondering if you have any feedback. |
This is a large change. I can't promise when I'll get to it. But, I'll try. |
6e4848f
to
a03b74c
Compare
Can someone merge this ? |
I'll try to look at this over the weekend. |
I like the idea of this, but it really should conform to Exhibitor's UI. It feels like it was just tacked on. If you don't have time to make the UI right, just remove it from the UI altogether and leave the REST API. |
@@ -0,0 +1,75 @@ | |||
package com.netflix.exhibitor.core.rest; | |||
|
|||
import com.amazonaws.util.json.JSONArray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not needed
a03b74c
to
5234412
Compare
Apologies for the UI side of things, it's not my strong suit. What changes to it would make it right for you? |
Look at how the other dialogs are done. It's pretty easy. I suck at UI. |
So I've been looking at this further and memories have come rushing back. The problem is that the import function loads a file that the user specifies. I couldn't find a way of doing that with without having a form submission. I didn't want to do that on the main page, as that seemed a poor user journey, so I created the popup window in order to do it. There is a plugin called jquery-file-upload, which I may be able to get to work. But it looks like there will be version mismatch issues with JQuery UI, so that will likely have to have its version bumped. So do you wish for us to just strip out the front-end code entirely, try this plugin or leave it as is, with the import being a separate window? |
I'd prefer to use the older jquery UI thing. It just looks odd to my eye otherwise. |
At first I thought we could use an older version of jquery-file-upload in order to use an older version of JQuery UI. But even the oldest available version uses a later version of JQuery UI than is currently used by Exhibitor. So an upgrade would probably be required. Also, currently we use a separate Jersey endpoint, Would you like the import code merged into |
Having looked at this some more, I remember now why there has to be a separate I have looked at trying to implement the front end using jquery-file-upload, but it's looking like it's going to be quite a large change that will involve changing a lot of the front end. So I'm resubmitting the pull request with just the server-side code, including the changes you asked for, within it and all the front end changes removed. |
5234412
to
b39175a
Compare
FYI - I'm in discussion with Netflix to move Exhibitor to its own repo so that it get better community support. Please stayed tuned. |
Allow exporting and importing znodes via JSON files.